18F / fedramp-automation

FedRAMP Automation
https://federalist-2372d2fd-fc94-42fe-bcc7-a8af4f664a51.app.cloud.gov/site/18f/fedramp-automation/
Other
15 stars 6 forks source link

SAP Validation Error for Included and Excluded Activites #733

Closed Telos-sa closed 11 months ago

Telos-sa commented 11 months ago

Describe the bug

When validating a FedRAMP OSCAL SAP, an error appears for terms & conditions parts that are misaligned with the NIST format.

What version of OSCAL are you using?

OSCAL version 1.0.0

How do we replicate the issue?

  1. Run the following SAP through the validator: FedRAMP Example Project_OSCAL_SAP.json.zip

  2. The following errors appear in 4.18 and 4.19 which states that the SAP terms and conditions require a part for 'included-activities' and 'excluded-activites'.

    Screenshot 2023-07-18 at 14 29 04

Expected behavior (i.e. solution)

These part names do not appear in the NIST format - based on the linked reference, "included-activites" should be named "assessment-inclusions" and "excluded-activities" should be "assessment-exclusions".

Telos-sa commented 11 months ago

Moved to https://github.com/GSA/fedramp-automation/issues/448