18F / fedramp-dashboard

https://marketplace.fedramp.gov
Creative Commons Zero v1.0 Universal
21 stars 16 forks source link

Micropurchase: Account for underlying and dependent products in agency and product listings #52

Closed lauraGgit closed 8 years ago

lauraGgit commented 8 years ago

Background

The FedRAMP marketplace is an Angular JS static site that relies on data pulled in via the Github api. This task seeks to update the product and agency listing pages in the site by modifying the controller.

Current State

Currently, when a user visits an Agency Page (i.e. NSF), in the list of Products Used only products that directly are listed in the data JSON.

For some products there are underlying products and dependent products (For instance an infrastructure product that is used by a SaaS product). In the product listing, there is a list of Dependent Products, which lists the products that leverage the product authorization. For example, Datapipe lists Accenture as a dependent product.

What we are asking

We would like to display the agency and product relationships for the underlying products in the agency and product page listings, and for the number of products used in per agency to reflect this change.

Specific Acceptance Criteria

All new functionality does not degrade code climate rating. All new functionality will be covered by new unit tests. There will be no decrease in test coverage. Tests run on Travis-CI and do not break the build. New features do not degrade accessibility (use pa11y/HTML Code Sniffer).

mgwalker commented 8 years ago

Evaluating. Will update this comment as I go.

lauraGgit commented 8 years ago

Closed by #53