Open nickbristow opened 8 years ago
Results can be recreated using HTML_CodeSniffer
#results > form
#results > div > drawer > button
<button class="fa fa-close" data-drawer-toggle="close" tabindex="-1"></button>
html > body > footer > div > div > div:nth-child(2) > div > a:nth-child(1)
<a href="#"> <span class="fa-...</a>
html > body > footer > div > div > div:nth-child(2) > div > a:nth-child(2)
<a href="https://twitter.com/GSAOSBU"> <span class="fa-...</a>
html > body > footer > div > div > div:nth-child(2) > div > a:nth-child(3)
<a href="https://www.youtube.com/playlist?list=PLvdwyPgXnxxVYR0faPu0NJ-dIXUqIVsUW"> <span class="fa-...</a>
html > body > footer > div > div > div:nth-child(2) > div > a:nth-child(4)
#opportunity-row
html
#agency
<form id="agency"> <div class="form-group...</form>
Errors: 9
@nickbristow I address these issues in #68. Once those changes are in, will the site be considered compliant, or do I also need to address the HTML Code Sniffer's warnings and notices?
@gemfarmer so the warnings and notices just mean they need to be checked by hand.
I just took a quick look, the main thing I'm seeing that wasn't picked up by the automated scan is the filters on the left side of the page.
They aren't accessible via the keyboard because they have a tabindex='-1'.
tabindex='-1'
That needs to be fixed. And once the PR goes through, go ahead and ping me and I can do a full manual review.
Ok. Will do. Thanks @nickbristow
Also, it looks like much of the by hand work is also intuitive heading size ordering. I might need to chat with you on Monday to gauge what is considered acceptable.
@nickbristow I think this is ready for a more thorough audit. I still haven't addressed the tabbing issue you mentioned above
Results can be recreated using HTML_CodeSniffer
Results for https://forecast-staging.18f.gov
#results > form