Using submodules cause Git Seekrets to output confusing error message.

18F / git-seekret

Git module to prevent from committing sensitive information into the repository.

Apache License 2.0

43 stars 3 forks source link

Using submodules cause Git Seekrets to output confusing error message. #18

Closed rogeruiz closed 7 years ago

rogeruiz commented 7 years ago

When git-seekrets is installed and you're working with a git repo that has submodules, git commit will give you a confusing error message about Object not found - no match for id ($hash_string) when you attempt to update and commit the submodule changes.

alain-hoang commented 7 years ago

git-seekret does not have features for working with submodules at this time. This would require major effort in order to support scanning of submodules.

LinuxBozo commented 7 years ago

Closing as confirmed fixed by #20 by @rogeruiz

$ git seekret check -s ; echo $?
Object not found - no match for id (772a7b031bd82d5eb73f130afc1760ac8b6fe409)
1

$ curl -s https://raw.githubusercontent.com/18F/laptop/master/seekrets-install | bash -

Installing Seekret
Installing in /usr/local/bin
...
Finished installing Seekret

$ git seekret check -s ; echo $?
0