search

18F / guides-style

DEPRECATED: 18F Guides Template style elements, derived from CFPB/DOCter
https://github.com/18F/uswds-jekyll
Other
11 stars 8 forks source link

convert to a gem-based theme #109

Closed afeld closed 6 years ago

afeld commented 6 years ago

Closes #73.

This fixes the theme to work for Jekyll 3.2+, and is easier to override. Was able to cut out a lot of custom logic that the gem-based themes now handle built-in to Jekyll.

https://jekyllrb.com/docs/themes/#creating-a-gem-based-theme

afeld commented 6 years ago

Tested with several sites locally. Only change required is adding theme: guides_style_18f in _config.yml, and using default instead of guides_style_18f_default for the layout.

screen shot 2017-10-26 at 4 10 00 pm

adborden commented 6 years ago

This looks great! I tried it out with the partnership playbook and everything works except the assets. The CSS is there, but all the assets are missing from _site.

adborden commented 6 years ago

... also some test errors when running ./go build https://gist.github.com/adborden/3a12488c3c156ccfd712562a24eaa5d1

afeld commented 6 years ago

@adborden Thanks for checking it out! Fixed the asset problem here (and confirmed it worked with your branch locally), and fixed the build in #111.

jeremiak commented 6 years ago

Just tried this out on the Handbook site and it works well. This PR looks good to me!