search

18F / guides-style

DEPRECATED: 18F Guides Template style elements, derived from CFPB/DOCter
https://github.com/18F/uswds-jekyll
Other
11 stars 8 forks source link

Update version of Jekyll used #84

Closed hbillings closed 7 years ago

hbillings commented 7 years ago

I'm totally not sure where this is in the codebase, but I know it relies on a really old version of Jekyll somewhere. That's no gud.

hbillings commented 7 years ago

http://guides.rubygems.org/patterns/#declaring-dependencies

hbillings commented 7 years ago

So, if I'm reading this issue correctly, the version of Jekyll can't exceed 3.1 if we want it to be compatible with the search plugin. Sad sad sad face.

It looks like there is no version of Jekyll specified in the guides-style plugin after all -- gemspec merely says s.add_runtime_dependency 'jekyll' without a version. Some guides, however, do seem to have their versions locked to 3.1.0 because of the aforementioned search issue.

afeld commented 7 years ago

Closed by #109.