18F / identity-analytics-etl

ETL and SQL scripts for Login.gov data warehouse and business intelligence
10 stars 6 forks source link

Add Funnel View Query Version1 #204

Closed MacHu-GWU closed 5 years ago

MacHu-GWU commented 5 years ago

labels: task

Summary

(Because #200 will be closed due to Git History disordered issue, will use this PR to replace #200)

Addresses Issue LG-965, implements funnel view query version1, without remember_device=True

Note, Why I removed the command line tool:

  1. Neither redshift and IDP DB have external SQL client access.
  2. psql -f xxx.sql -v var=value requires NO such \set var = xxx in sql scripts. But those sql scripts should be ready for making sql query. And we need the \set var = xxx part to be in sql.
  3. If we really want to reuse those queries and make them machine-readable, I think we could implement a python scripts to execute SQL with parameters.

Please note if fully resolves the issue per the acceptance criteria: Y

Describe the pull request here, including any supplemental information needed to understand it.

This pull request is ready to merge when...