LG-10950 Upgrade ruby and rails - Githubissues

18F / identity-dashboard

Identity developer dashboard

22 stars 11 forks source link

LG-10950 Upgrade ruby and rails #707

Closed Sgtpluck closed 8 months ago

Sgtpluck commented 8 months ago

WIP

Relevant Ticket or Conversation:

https://cm-jira.usa.gov/browse/LG-10950

Description of Changes:

Upgrading Ruby and Rails to be on par with IdP

Ruby 3.2.0 (IdP currently on 3.2.2) Rails 6.1.7.3 (IdP currently on 7.0.7.2)

PR Checklist:

[ ] Have you linted and tested your code locally prior to submission?
[ ] Have you tagged the appropriate dev(s) for review?
[ ] Have you linked to any relevant tickets or conversations?

PR Review Standards:

Consider using Conventional Comments to ensure that your feedback is clear and actionable.
Ideally, PRs should be reviewed by at least 2 team members.
All PRs must be approved before being merged.

Sgtpluck commented 8 months ago

@mitchellhenke i am a little wary too, honestly. it does work locally, but since we squash commits, it probably would be better to break it into two pieces especially since the logo handling is different in development. ok just writing out this comment has convinced me that that will be better, so i will remove the last two commits of this PR and open a new one!