18F / identity-idp

Login.gov Core App: Identity Provider (IdP)
https://secure.login.gov/
Other
524 stars 112 forks source link

LG-14492 Accept a string in the ipp helper scrub method #11269

Closed jennyverdeyen closed 1 month ago

jennyverdeyen commented 1 month ago

🎫 Ticket

Link to the relevant ticket: LG-14492

🛠 Summary of changes

Errors in NewRelic revealed that some USPS exceptions include a response body with a String instead of a hash, but we were assuming the body would be a hash in our method to scrub it for sponsor ID, causing the error undefined method 'with_indifferent_access' for instance of a String.

This accepts a String and still ensures that it is scrubbed of a sponsor ID.

📜 Testing Plan