Closed jmax-gsa closed 3 weeks ago
Hi just some feedback, the squashed merge commit for this PR didn't properly preserve the changelog:
line, please keep that in mind for future merges!
Oh, bugger. Thanks.
On Thu, Oct 10, 2024 at 3:03 PM Zach Margolis @.***> wrote:
Hi just some feedback, the squashed merge commit for this PR https://github.com/18F/identity-idp/commit/0fb7e7003d2264a4442227745cf55c63ba61a02c didn't properly preserve the changelog: line, please keep that in mind for future merges!
— Reply to this email directly, view it on GitHub https://github.com/18F/identity-idp/pull/11289#issuecomment-2405837879, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYEGBLWUHWZNR56M4UKNOCLZ23FORAVCNFSM6AAAAABO5T2K2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBVHAZTOOBXHE . You are receiving this because you modified the open/close state.Message ID: @.***>
🎫 Ticket
Link to the relevant ticket: LG-14005 LG-13992
🛠 Summary of changes
Added controllers for hand-off to Socure, and code to get the hand-off URL from Socure. Doesn't actually do the handoff; just displays an interstitial page with the link.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
These tests must be run in a local dev environment.
HOST=0.0.0.0 make run
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Interstitial page
![image](https://github.com/user-attachments/assets/0ff4758f-89bc-48f7-9781-059d7d2745b7)