LG-14587 | Updates to 'You successfully verified your identity' email

[n1zyy]

🎫 Ticket

Link to the relevant ticket: LG-14587

🛠 Summary of changes

[!IMPORTANT] There is a desire from leadership/product to have this story go out in the next deploy (October 1). If reviewers have suggested changes, I'd be grateful if you can be clear which are blocking and which can be resolved in a follow-up story if need be. (I'll try to get them all fixed ahead of time, though!)

In this story, we make some changes to the account_verified email. Namely:

• The email gets a bit of a facelift
• When an SP is present, the user is prompted to return to the SP to try to reduce abandonment
• It continues to contain the 800-63 elements required for confirmation
• New translations from Department of State are used

👀 Screenshots

You can preview the message at https://review-mattw-lg-1-jygxb8.reviewapps.identitysandbox.gov/rails/mailers/user_mailer/account_verified

Please note that the screenshots below were taken before this change: https://github.com/18F/identity-idp/pull/11295/commits/db541009710b51f245edbff6447a693b38298c33

With Service Provider with `return_to_sp_url` specified

(Note that `localhost:9292` is the Service Provider's URL, Example Sinatra App here.)    

With Service Provider with NO return_to_sp_url

(I set the fictional SP name to "The FBI" because it made for a cool demo. Because there is no `return_to_sp_url`, the user is just told to sign into the SP but there's nothing we can link to, so we omit the link/button.)    

With NO service provider

(Note that `localhost:3000` is equivalent to Login.gov in prod: i.e., with no SP, the user is prompted to sign into Login.gov directly.)    

[n1zyy]

There is one failing test:

  1) I18n config/locales/es.yml does not contain any translations that hardcode APP_NAME
     Failure/Error: expect(bad_keys).to be_empty
       expected `{"user_mailer.account_verified.contact_link"=>"contacte con el servicio de asistencia de Login.gov"}.empty?` to be truthy, got false

I am going to deal with this Monday morning. The problem is that this string is "contact us" in other languages, but they made the Spanish one include the string "Login.gov" so now the linter is angry. 🙀

[matthinz]

The email looked good in all the clients I was able to test in. Maybe slightly wonky in macOS mail, but what isn't? That is, this is not something we're going to fix in this PR!

macOS mail

Gmail (iOS)