18F / identity-idp

Login.gov Core App: Identity Provider (IdP)
https://secure.login.gov/
Other
524 stars 112 forks source link

Use a list to log resolved ACRs in events #11307

Closed lmgeorge closed 3 weeks ago

lmgeorge commented 1 month ago

🛠 Summary of changes

Why

How

changelog: Internal, Analytics, Streamlining inclusion of resolved ACR names

resolves: https://gitlab.login.gov/lg-people/Melba/backlog-fy24/-/issues/112

🎫 Ticket

Link to the relevant ticket: https://gitlab.login.gov/lg-people/Melba/backlog-fy24/-/issues/112

📜 Testing Plan

  1. [ ] Create an account via the sample app
    • Note: Make sure to test with both an IdV enabled and disabled SP
  2. [ ] Check the events.log (locally or in Cloudwatch) and verify that components_values is displaying as an array
  3. [ ] Repeat steps 1-2 for auth-only user, verified user, a verified user that has been proofed with selfie (facial match).
    • Note: Pay special attention when going through the "facial match preferred" flow.

Additional notes

This will require updating Cloudwatch queries. Impacted ones are listed in the linked ticket.