18F / identity-idp

Login.gov Core App: Identity Provider (IdP)
https://secure.login.gov/
Other
524 stars 112 forks source link

LG-14642: Update design and copy of GPO 'letter on the way' email #11351

Closed lmgeorge closed 1 week ago

lmgeorge commented 2 weeks ago

Why

How

Additional Notes As we utilize Rails.application.routes.url_helpers directly in the presenter, LocaleHelper#with_user_locale also needed to handle updating the locale within the url_options hash while also maintaining support for services that do not use url_helpers directly (e.g., SendProofingNotificationJob).

By default, it appears that Rspec mocks url_options with a frozen hash, so we simply override it for the purposes of testing. A scenario where url_options is defined but equal to nil is not supported. In the event this happens, we want the interpreter to throw an error because it likely indicates a serious misconfiguration or bug in the app.

changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification

🎫 Ticket

Link to the relevant ticket: LG-14642

lmgeorge commented 2 weeks ago

Author's note: currently waiting for program requirements to be met before this can be merged , but review and acceptance can still happen!

This work has been accepted, but still needs final business approval from program.