Closed lmgeorge closed 1 week ago
Author's note: currently waiting for program requirements to be met before this can be merged , but review and acceptance can still happen!
This work has been accepted, but still needs final business approval from program.
Why
How
Idv::ByMail::LetterRequestedPresenter
).user_mailer.letter_reminder.*
with new message properties underuser_mailer.verify_by_mail_letter_requested.*
Additional Notes As we utilize
Rails.application.routes.url_helpers
directly in the presenter,LocaleHelper#with_user_locale
also needed to handle updating the locale within theurl_options
hash while also maintaining support for services that do not useurl_helpers
directly (e.g.,SendProofingNotificationJob
).By default, it appears that Rspec mocks
url_options
with a frozen hash, so we simply override it for the purposes of testing. A scenario whereurl_options
is defined but equal tonil
is not supported. In the event this happens, we want the interpreter to throw an error because it likely indicates a serious misconfiguration or bug in the app.changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification
🎫 Ticket
Link to the relevant ticket: LG-14642