I realized that this bug existed in the below emails:
in_person_verified
in_person_failed
in_person_failed_fraud
Additionally, the in_person_deadline_passed email template included variables it didn't need, such as the formatted_verified_date from the presenter. I removed the superfluous variables.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
[ ] Inspect the in_person_please_call email via http://localhost:3000/rails/mailers/user_mailer/in_person_please_call. Confirm it looks the same on this branch as it does on main, and that no regressions have been introduced by this PR.
[ ] Inspect the in_person_deadline_passed email via http://localhost:3000/rails/mailers/user_mailer/in_person_deadline_passed. Confirm it looks the same on this branch as it does on main, and that no regressions have been introduced by this PR.
[ ] Inspect the in_person_verified email via http://localhost:3000/rails/mailers/user_mailer/in_person_verified. Confirm that the displayed location name is no longer the same as the location name displayed in the in_person_ready_to_verify email.
[ ] Inspect the in_person_failed email via http://localhost:3000/rails/mailers/user_mailer/in_person_failed. Confirm that the displayed location name is no longer the same as the location name displayed in the in_person_ready_to_verify email.
[ ] Inspect the in_person_failed_fraud email via http://localhost:3000/rails/mailers/user_mailer/in_person_failed_fraud. Confirm that the displayed location name is no longer the same as the location name displayed in the in_person_ready_to_verify email.
👀 Screenshots
I only included English-language screenshots because we didn't change translations. The change in post office name should apply to the emails in all languages. If design would like, I can also upload screenshots of all supported languages.
@eileen-nava this LGTM. As you pointed out, the Post Office name will not be different in other languages so I'm okay approving this with the English screenshots!
🎫 Ticket
LG-14624: Fix bug where verified email shows selected post office location instead of visited post office location
🛠Summary of changes
I realized that this bug existed in the below emails:
Additionally, the in_person_deadline_passed email template included variables it didn't need, such as the formatted_verified_date from the presenter. I removed the superfluous variables.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
in_person_please_call
email viahttp://localhost:3000/rails/mailers/user_mailer/in_person_please_call
. Confirm it looks the same on this branch as it does onmain
, and that no regressions have been introduced by this PR.in_person_deadline_passed
email viahttp://localhost:3000/rails/mailers/user_mailer/in_person_deadline_passed
. Confirm it looks the same on this branch as it does onmain
, and that no regressions have been introduced by this PR.in_person_verified
email viahttp://localhost:3000/rails/mailers/user_mailer/in_person_verified
. Confirm that the displayed location name is no longer the same as the location name displayed in thein_person_ready_to_verify
email.in_person_failed
email viahttp://localhost:3000/rails/mailers/user_mailer/in_person_failed
. Confirm that the displayed location name is no longer the same as the location name displayed in thein_person_ready_to_verify
email.in_person_failed_fraud
email viahttp://localhost:3000/rails/mailers/user_mailer/in_person_failed_fraud
. Confirm that the displayed location name is no longer the same as the location name displayed in thein_person_ready_to_verify
email.👀 Screenshots
I only included English-language screenshots because we didn't change translations. The change in post office name should apply to the emails in all languages. If design would like, I can also upload screenshots of all supported languages.
in_person_please_call_email Before:
![InPersonPleaseCallEmailBEFORE](https://github.com/user-attachments/assets/a2f312e3-246f-4283-a917-b0c66d4e2a21)in_person_please_call_email After:
![InPersonPleaseCallEmailAFTER](https://github.com/user-attachments/assets/417fba0c-e016-41f8-af77-6f9526a3f297)in_person_deadline_passed email Before:
![InPersonDeadlinePassedEmailBEFORE](https://github.com/user-attachments/assets/dd54d92e-5d18-433c-bbfd-2b95369a3e6b)in_person_deadline_passed email After:
![InPersonDeadlinePassedEmailAFTER](https://github.com/user-attachments/assets/b765f238-e686-4842-b399-1201ffa5a40c)in_person_verified email Before:
![InPersonVerifiedBEFORE](https://github.com/user-attachments/assets/b981d31d-5439-4c8a-8347-d304ea1d5161)in_person_verified email After:
![InPersonVerifiedEmailAFTER](https://github.com/user-attachments/assets/d5b701f7-1fd8-455d-a2be-98022fb95daf)in_person_failed email Before:
![InPersonFailedEmailBEFORE](https://github.com/user-attachments/assets/9f71e17f-c07a-4b85-8164-5aa205d5f545)in_person_failed email After:
![InPersonFailedEmailAFTER](https://github.com/user-attachments/assets/0a3508c4-d9c7-4468-b3a1-c8ef8e3695ff)in_person_failed_fraud email Before:
![InPersonFailedFraudEmailBEFORE](https://github.com/user-attachments/assets/3afdb926-4ee1-4c3f-816f-4816f0c9cdac)in_person_failed_fraud email After:
![InPersonFailedFraudEmailAFTER](https://github.com/user-attachments/assets/da061e30-1d6a-4e14-92e3-3c023149d992)