search

18F / identity-idp

Login.gov Core App: Identity Provider (IdP)
https://secure.login.gov/
Other
524 stars 112 forks source link

Remove some spacing in zh.yml #11356

Closed nickttng closed 2 weeks ago

nickttng commented 2 weeks ago

In this PR, I'm requesting an engineer(s) to review.

🎫 Ticket

Link to the relevant ticket: LG-14803

🛠 Summary of changes

As part of Chinese (Simplified) quality assurance check, I am deleting the extra spacing in several instances that DOS is requesting to remove.

SBAR details in the document.

📜 Testing Plan

Only extra spacing in certain instances are deleted.

No characters, symbols, or punctuation marks are deleted.

nickttng commented 2 weeks ago

@aduth Thanks for the review.

Question: How might I get this to pass one of the items in the GitLab stage?

aduth commented 2 weeks ago

You need to include a commit that includes a changelog in the expected format:

https://github.com/18F/identity-idp/blob/main/CONTRIBUTING.md#changelog-messages

Something like this should work:

git commit -m "Add changelog" -m "changelog: User-Facing Improvements, Content, Improve text spacing for some content in Simplified Chinese" --allow-empty
git push