search

18F / jekyll_pages_api

a Jekyll Plugin that generates a JSON file with data for all the Pages in your Site
Other
43 stars 14 forks source link

remove skip_index #34

Open afeld opened 8 years ago

afeld commented 8 years ago

The skip_index option doesn't have any effect on the API results, so it isn't relevant for this plugin. It appears that there is some related code in the search plugin:

https://github.com/18F/jekyll_pages_api_search/search?utf8=%E2%9C%93&q=skip_index

so not sure if it needs to be migrated, or can simply be safely removed. Alternatively, skip_index could be used to exclude the page from the pages.json, but I can't think of a good reason why someone would want to do that.

kellymason commented 7 years ago

I'll take a look at this one!

kellymason commented 7 years ago

@afeld I looked into this - it seems like the information still needs to be passed into pages.json so that jekyll_pages_api_search can appropriately exclude any pages with this flag present. Right?