Closed mbland closed 9 years ago
@afeld I think this is ready for a proper look now.
cc: @adelevie, since Aidan's mostly out this week.
Alan, notice that #2 depends on this going in first.
Blocked by https://github.com/18F/jekyll_pages_api_search/issues/3, @mbland.
Holy hell that was a big PR :sweat_smile: Nothing's a blocker, so merging now so that we can have smaller, more focused PRs going forward.
Did you mean to commit the minified (non-3rd party) JS files? Would be nice to have those compiled on the first build and be done with it, so that we don't need to remember to update them.
You can see these in action in the search-plugin branch of 18F/hub.
Next step would be to copy the JavaScript files to the generated site; then I think it's more or less complete.
cc: @afeld