Replace search results drop-down with results page

18F / jekyll_pages_api_search

DEPRECATED - Jekyll search plugin based on lunr.js and jekyll_pages_api

https://rubygems.org/gems/jekyll_pages_api_search

Other

39 stars 8 forks source link

Replace search results drop-down with results page #15

Closed mbland closed 8 years ago

mbland commented 8 years ago

This contains enough implementation to drive basic search page functionality for the 18F Handbook. More work is needed.

Note that this is still 100% server-side Lunr.js indexing and 100% client-side Lunr.js serving. This doesn't interfere with the 18F/lunr-search functionality whatsoever, though it may help inform how we style the results from the lunr-search server.

cc: @andrewmaier @mtorres253 @catherinedevlin @ccostino @ertzeid @afeld

handbook-demo

mbland commented 8 years ago

I've just reworked some more and pulled bits from 18F/guides-style#48 so that the widget and its style is more portable out-of-the-box:

guides-search-demo

mbland commented 8 years ago

OK gang, I think this is actually ready to go in. Would appreciate a review; happy to break it into separate pieces if this is too much.

I'll close #9, since this PR supersedes it. I'm investigating using PhantomJS to drive some interface tests, but I don't think that need be a blocker.

Also, I'll add Rubocop and ESLint to do some code cleanup in a later PR. I've already started work in the cleanup branch.