search

18F / jekyll_pages_api_search

DEPRECATED - Jekyll search plugin based on lunr.js and jekyll_pages_api
https://rubygems.org/gems/jekyll_pages_api_search
Other
39 stars 8 forks source link

Update search.html #23

Closed andrewmaier closed 8 years ago

andrewmaier commented 8 years ago

Add text to the label element for screen readers. Also removing the extraneous div surrounding the form.

See: http://www.456bereastreet.com/archive/201204/the_html5_placeholder_attribute_is_not_a_substitute_for_the_label_element/

cc @mbland

mbland commented 8 years ago

The search functionality still works, but the style is now off, as evidenced by building 18F/guides-template with a gem 'jekyll_pages_api_search', path: '../jekyll_pages_api_search' entry. Can you tweak the styles in lib/jekyll_pages_api_search/sass/jekyll_pages_api_search.scss and add them to this PR?

search-style-00

andrewmaier commented 8 years ago

@mbland Ready!

image

mbland commented 8 years ago

Pushed a fix for the test failure, and checked the Guides Template and Handbook with the update. The only thing that doesn't look quite right is the Handbook home page itself, but I figure you know how to fix it on that end. Merging.

handbook-00