18F / jekyll_pages_api_search

DEPRECATED - Jekyll search plugin based on lunr.js and jekyll_pages_api
https://rubygems.org/gems/jekyll_pages_api_search
Other
39 stars 8 forks source link

Add missing step to release instructions #28

Closed mbland closed 8 years ago

mbland commented 8 years ago

cc: @jbarnicle

jbarnicle commented 8 years ago

@mbland - do you mind updating this to spell out the actual git commands as well (for those like myself that are a little less familiar with tagging etc.)

mbland commented 8 years ago

@jbarnicle Done. Let me know how it reads now.

jbarnicle commented 8 years ago

Thanks @mbland. Making this comment again because it might have gotten swallowed up in a line note. I spoke with @afeld - and I think we're planning on releasing this on Monday for coverage sake. That doesn't interfere with anything on your end, does it?

mbland commented 8 years ago

Heh, lemme repost my response:

git add is the command to stage changes for git commit. http://git-scm.com/documentation is a good intro to git in general.

It would be preferable for me to cut v0.4.4 now, so I can get apps.gov to depend on it directly. No other sites will be affected, and you can wait until Monday to push it to 18F/guides-template yet so most of the Pages sites will get the new JavaScript (which is functionally the same as the 0.4.3, just refactored).

mbland commented 8 years ago

Actually, correction: jekyll_pages_api_search actually doesn't propagate the way other JavaScript files from guides_style_18f propagates, so cutting 0.4.4 won't affect any existing Pages sites until individual sites upgrade their jekyll_pages_api_search version.

jbarnicle commented 8 years ago

Ok - so here's my confusion surrounding add. If in step 2) I have edited version.rb - wouldn't it already be staged (making it really only a git commit -m...')

Working on pushing now

mbland commented 8 years ago

Nope, changes aren't staged until they're git added. If you specify the file to commit as part of the git commit, you're bypassing the git add step. Check out the docs on the git "index".

Thanks for the push! :smiley:

jbarnicle commented 8 years ago

Released.

mbland commented 8 years ago

Thanks a ton!