Add RaaS Roles - Githubissues

18F / joining-18f

A guide for anyone interested in joining the 18F team

https://pages.18f.gov/joining-18f/

Other

36 stars 28 forks source link

Add RaaS Roles #310

Closed rooneywp closed 8 years ago

rooneywp commented 8 years ago

IN PROGRESS

Adding the messaging for the new section to house the RaaS roles & links to position descriptions

fureigh commented 8 years ago

@rooneywp This one isn't yet ready for review, correct?

fureigh commented 8 years ago

@rooneywp Given our conversation in Slack, I'll assume you'd like me to review this.

Two initial things:

The federal government benefits link referenced in all of these posts (https://www.usajobs.gov/ResourceCenter/Index/Interactive/Benefits#icc) yields a 404 error (see below). Can you update the link and check that all remaining links work as intended?

Several of the pull requests reviewed and merged were based off of other branches created for pull requests, not off of the main 18f-pages branch, so things are a bit muddled at the moment. Let's sort those out, merge them into this branch, push it to staging, and then we'll be able to confirm we're good to go.

rooneywp commented 8 years ago

@fureigh Yeah, I thought something was weird. I must have done something wrong when I was creating the new files.

I'll update the benefits links.

rooneywp commented 8 years ago

@fureigh Don't worry about rushing to get this done tonight. We can get it up in the AM.

fureigh commented 8 years ago

@rooneywp Patience appreciated, but I'm in workshop mode for the rest of this week, so best to wrap it up tonight if possible. Aiming to get the branches sorted before this plane lands, after which you can make further edits at your convenience.

fureigh commented 8 years ago

Merged branch rooneywp-patch-6.

fureigh commented 8 years ago

Okay, branches appear to be sorted. I pushed to staging but 2FA is locking me out while I'm on a plane and don't have the ability to access texts. Problems of living in the future!

@rooneywp, can you review on staging? In particular, please verify that the links all work and are formatted correctly.

fureigh commented 8 years ago

No pressure to do that tonight, of course; it's up to you. Everything is now in this PR and on staging, including the commits that were already merged to 18f-pages.