18F / laptop

DEPRECATED: A shell script which turns your Mac into an awesome web development machine.
https://github.com/18F/handbook/pull/2186
Other
316 stars 91 forks source link

Fix nvm LTS install #167

Closed mgwalker closed 5 years ago

mgwalker commented 5 years ago

The command nvm install node --lts installs the latest version of Node.js, not the latest LTS version. To fix, remove node. This seems to be a change in the behavior of nvm.

Additionally, the mac script is configured to exit if any command within it exits with a non-zero code. However, nvm is itself a bash script that has commands that have non-zero exit codes that are NOT exceptional. That is, a successful nvm install may include some commands exiting with non-zero statuses. To handle that, this PR also disables the "exit if anything is non-zero" when it runs nvm and re-enables it afterwards.

Closes #166