Add Fish shell support - Githubissues

18F / laptop

DEPRECATED: A shell script which turns your Mac into an awesome web development machine.

https://github.com/18F/handbook/pull/2186

Other

316 stars 91 forks source link

Add Fish shell support #169

Closed rahearn closed 5 years ago

rahearn commented 5 years ago

Adds support for using fish as the developer shell (#164).

Changes from the zsh/bash setup:

rbenv for ruby version management.

Rough edges:

nvm is installed, but doesn't work in fish without a wrapper. A link to a potential wrapper is provided during the run.

rahearn commented 5 years ago

@mgwalker Let me know what you think about dropping the append_to_posix_shell_file function entirely and moving a couple more case "$SHELL" statements into the main body. I think that would be a little clearer in intention, at the cost of a little more code duplication.

mgwalker commented 5 years ago

I think some kind of append_to_shell_file function makes sense, distinct from just append_to_file. The append_to_shell_file can have a case "$SHELL" to distinguish between fish and everything else. The reason I favor having a special function is that append_to_file "$shell_file" appears in 12 places in the pre-PR code, so that's a lot of duplication in shell checking.