seekret-rule Brainstorming

cryptofilegsa commented 7 years ago

Some Sources of Ideas for Rules:

[ ] Private SSH key
[ ] SSH configuration file
[ ] Potential cryptographic private key
[ ] Potential cryptographic key bundle
[ ] Web browser history file
[ ] Any single-sign-on credential storage file
[ ] Contains word: backup
[ ] Contains word: dump
[ ] Contains word: password
[ ] Contains word: credential
[ ] Contains word: secret
[ ] Contains words: private, key
[ ] Pidgin OTR private key
[ ] Shell command history file
[ ] MySQL client command history file
[ ] PostgreSQL client command history file
[ ] Eclipse configuration file
[ ] JBoss configuration xml
[ ] PostgreSQL password file
[ ] Ruby IRB console history file
[ ] Pidgin chat client account configuration file
[ ] Hexchat/XChat IRC client server list configuration file
[ ] Irssi IRC client configuration file
[ ] Mutt e-mail client configuration file
[ ] AWS CLI credentials file
[ ] T command-line Twitter client configuration file
[ ] OpenVPN client configuration file
[ ] Shell configuration file
[ ] Shell profile configuration file
[ ] Shell command alias configuration file
[ ] Ruby On Rails secret token configuration file
[ ] OmniAuth configuration file
[ ] any files containing KEK or key files for data store access in java
[ ] Ruby On Rails database schema file
[ ] Potential Ruby On Rails database configuration file
[ ] Django configuration file
[ ] PHP configuration file
[ ] KeePass password manager database file
[ ] 1Password password manager database file
[ ] Apple Keychain database file
[ ] GNOME Keyring database file
[ ] Generic system log file
[ ] Network traffic capture file
[ ] SQL dump file
[ ] Jenkins publish over SSH plugin file
[ ] Potential Jenkins credentials file
[ ] Apache htpasswd file
[ ] Configuration file for auto-login process
[ ] KDE Wallet Manager database file
[ ] Potential MediaWiki configuration file
[ ] Tunnelblick VPN configuration file
[ ] Rubygems credentials file
[ ] Potential MSBuild publish profile
[ ] Sequel Pro MySQL database manager bookmark file
[ ] git-credential-store helper credentials file
[ ] Git configuration file
[ ] Chef Knife configuration file
[ ] Chef private key
[ ] cPanel backup ProFTPd credentials file
[ ] Robomongo MongoDB manager configuration file
[ ] FileZilla FTP configuration or recent servers list
[ ] Docker configuration file
[ ] Environment configuration file

rogeruiz commented 7 years ago

From @monfresh https://github.com/18F/laptop/pull/69#issuecomment-266537861

If Ruby On Rails database schema file refers to something like what you would find in db/schema.rb in a typical Rails app, then it doesn't belong in the aforementioned list because that file is supposed to be checked into version control. When Rails generates this file, you'll notice the following comment:

It's strongly recommended that you check this file into your version control system.

Same with Ruby On Rails secret token configuration file and Potential Ruby On Rails database configuration file. Those files are typically checked into Git. It's not the files themselves that are an issue, it's whether or not they contain sensitive information that should be stored in an ENV var instead.

rogeruiz commented 7 years ago

Lots of great insight when pushing git-seekrets out the door. One is that the regular expressions that we create should be specifically tied to documented ways that secrets can be included in a codebase. For other things that were mentioned above, I think having more general categories rather than one-off rules for each item in that list would be much better.

For now though the three we have are perfect. I hope more people contribute some regular expressions in the future. We've got docs for it now. 👍

https://github.com/18F/laptop/tree/seekret#git-seekret

cryptofilegsa commented 7 years ago

also, a rule for equifax credentials...

18F / laptop

seekret-rule Brainstorming #86