18F / legalese

experimental legal language checker for third-party services
Other
7 stars 7 forks source link

rescued from exception in sample script #11

Closed DanielWolkowitz closed 7 years ago

DanielWolkowitz commented 7 years ago

Running bundle exec ruby scan.rb turned up errors for websites with certificate issues and stops the search in terminal. Adding the rescue exception allows the user to continue through the urls.txt file without stopping the search, yet still displaying the error (which shows as "Failed with #{url} due to OpenSSL errors").

afeld commented 7 years ago

This is great, thanks! If you are game to follow up with adding an automated test, that would be 🙌 😉

afeld commented 7 years ago

Also, we might want to consider moving the exception handling further into the classes, which will make it easier to test.