search

18F / linkify-citations

Turns legal citations in the DOM into links
Other
20 stars 12 forks source link

Is it worth pulling in citation.js as a dependency? #8

Closed ascott1 closed 9 years ago

ascott1 commented 9 years ago

Rather than embedding the minified version of citation.js directly in the file, should it be pulled in as a dependency? This would require a build step, but seems cleaner option and an easier way to keep up with potential changes to citation.js.

vdavez commented 9 years ago

Hi @ascott1. So, I actually did this as part of a refactor, see https://github.com/18F/linkify-citations/blob/master/src/linkify-citations.js and https://github.com/18F/linkify-citations/blob/master/package.json#L9

ascott1 commented 9 years ago

:clap: