search

18F / marigold

An experimental set of reusable components and patterns for making websites and applications at 18F/TTS.
http://federalist.18f.gov.s3-website-us-east-1.amazonaws.com/site/18F/marigold/
Other
10 stars 6 forks source link

Added United ACSS framework as proof-of-concept #44

Closed thisisdano closed 7 years ago

thisisdano commented 7 years ago

I added the latest build of the United framework (https://github.com/18F/united) and the most recent builds of 18Franklin (https://github.com/18F/18Franklin). I also created a test component to see if it was all working properly.

screen shot 2017-01-24 at 8 34 42 am

In the (not too distant) future, both United and 18Franklin could be set up as Node modules and get included as dependencies (and perhaps also npm linked as we did with cg-style) — but I'd need more guidance on how to do this, best practices, etc.

For now, though, this is a proof-of-concept to show how United could integrate into Marigold.

juliaelman commented 7 years ago

@thisisdano thank you for your pull request and the proof of concept.

Since we have not synthesized and compiled any results from the research we are currently doing, I don't think we are quite ready to incorporating these changes into Marigold. It's a pretty big stylistic change and one that the team has not had a chance to think about yet.

Also, let's try to keep pull requests as small and incremental as possible. This helps any reviewers move quickly, which is of the utmost importance especially on internal projects. A good way to achieve this is to create issues with a list of items needed to accomplish the end goal. Some folks list them out as acceptance criteria for when an issue can be closed.

I'll be closing this issue and we can re-visit this approach once our research is completed ☮️