search

18F / micropurchase

18F's micro-purchase threshold experiment management app.
https://micropurchase.18f.gov
Other
68 stars 37 forks source link

Added single logout link for saml auth sessions #1496

Closed nickbristow closed 7 years ago

nickbristow commented 7 years ago

Logout path is different for users who auth with saml

jessieay commented 7 years ago

Closing this in favor of https://github.com/18F/micropurchase/pull/1497

Note that 1497 does not include a feature spec for logging out an admin. I think we should still aim to write one, but in order to get that to pass I had to change the URL in config/secrets.yml to idp_slo_url: http://idp.example.com/auth/saml/logout, which then broke our request specs. I couldn't figure out why after about an hour so my calculation is that we should move on and tackle figuring this out when there is value in doing so.