18F / micropurchase

18F's micro-purchase threshold experiment management app.
https://micropurchase.18f.gov
Other
68 stars 37 forks source link

Hotfix update deps #1517

Closed adelevie closed 7 years ago

adelevie commented 7 years ago

Getting these errors:

Failures:

  1) SSO user is not an admin does not sign in the user
     Failure/Error: expect(response).to redirect_to('http://www.example.com/')

       Expected response to be a redirect to <http://www.example.com/> but was a redirect to <http://www.example.com/auth/failure?message=invalid_ticket&strategy=saml>.
       Expected "http://www.example.com/" to be === "http://www.example.com/auth/failure?message=invalid_ticket&strategy=saml".
     # ./spec/requests/sso_spec.rb:24:in `block (3 levels) in <top (required)>'

  2) SSO user is an admin uses external SAML IdP to sign in the user
     Failure/Error: expect(response).to redirect_to('http://www.example.com/admin/auctions/needs_attention')

       Expected response to be a redirect to <http://www.example.com/admin/auctions/needs_attention> but was a redirect to <http://www.example.com/auth/failure?message=invalid_ticket&strategy=saml>.
       Expected "http://www.example.com/admin/auctions/needs_attention" to be === "http://www.example.com/auth/failure?message=invalid_ticket&strategy=saml".
     # ./spec/requests/sso_spec.rb:44:in `block (3 levels) in <top (required)>'

  3) SLO SP-initiated uses external SAML IdP
     Failure/Error: settings.name_identifier_value = current_user.uid

     NoMethodError:
       undefined method `uid' for #<Guest:0x0000000b592cd8>
     # ./app/controllers/saml_authentications_controller.rb:90:in `sp_logout_request'
     # ./app/controllers/saml_authentications_controller.rb:22:in `destroy'
adelevie commented 7 years ago

closing in favor of https://github.com/18F/micropurchase/pull/1519

adelevie commented 7 years ago

@amoose thank you 🐲