Closed mkhandekar closed 9 years ago
@mkhandekar thanks for the pull request! :+1:
Just to confirm, the changes made in this pull request are to adjust the sizing to spec on larger screen sizes - correct?
@juliaelman That's right, adjustments were made for larger screen sizes.
@mkhandekar great! I just pushed up some fixes for your review and hope that fixes the spacing issues on smaller screen sizes.
@adelevie once approved, I can merge these changes into the starter
branch and I think we should be good to go?
Yep, @juliaelman. Last piece will be the email form. I am planning to add this myself later today, unless this is something either you or @mkhandekar wants to add.
@adelevie ah, ok! I was wondering what we were doing about that, based on the original design. Happy to add it to this PR shortly.
@adelevie @mkhandekar added the input field + submit button + their responsive behavior! :tada:
This all looks fantastic. Excellent work @mkhandekar and @juliaelman!
Latest commit fixes the previous two accessibility issues.
This pull request includes adjustments including:
Help needed: Generally this is the spacing I'm looking for between 1) box border & top of logo, and 2) bottom box border and top of "we're currently upgrading". When I resize the browser window, this spacing reduces, and I don't quite know how to retain similar (or at least proportional) spacing on smaller screen sizes. Any ideas @adelevie & @juliaelman?
Target:
Regular / desktop:
Smaller sizes / responsive