18F / myusa-coming-soon

[DEPRECATED] A coming soon page for MyUSA
https://my.usa.gov
Other
1 stars 2 forks source link

typography & spacing changes #3

Closed mkhandekar closed 9 years ago

mkhandekar commented 9 years ago

This pull request includes adjustments including:

Help needed: Generally this is the spacing I'm looking for between 1) box border & top of logo, and 2) bottom box border and top of "we're currently upgrading". When I resize the browser window, this spacing reduces, and I don't quite know how to retain similar (or at least proportional) spacing on smaller screen sizes. Any ideas @adelevie & @juliaelman?

Target: myusa_comingsoon_v4c

Regular / desktop: desktop

Smaller sizes / responsive responsive

juliaelman commented 9 years ago

@mkhandekar thanks for the pull request! :+1:

Just to confirm, the changes made in this pull request are to adjust the sizing to spec on larger screen sizes - correct?

mkhandekar commented 9 years ago

@juliaelman That's right, adjustments were made for larger screen sizes.

juliaelman commented 9 years ago

@mkhandekar great! I just pushed up some fixes for your review and hope that fixes the spacing issues on smaller screen sizes.

@adelevie once approved, I can merge these changes into the starter branch and I think we should be good to go?

adelevie commented 9 years ago

Yep, @juliaelman. Last piece will be the email form. I am planning to add this myself later today, unless this is something either you or @mkhandekar wants to add.

juliaelman commented 9 years ago

@adelevie ah, ok! I was wondering what we were doing about that, based on the original design. Happy to add it to this PR shortly.

juliaelman commented 9 years ago

@adelevie @mkhandekar added the input field + submit button + their responsive behavior! :tada:

2 looks like it syncs up with this work.

adelevie commented 9 years ago

This all looks fantastic. Excellent work @mkhandekar and @juliaelman!

adelevie commented 9 years ago

screen shot 2015-04-09 at 1 29 05 pm

adelevie commented 9 years ago

screen shot 2015-04-09 at 1 37 01 pm

adelevie commented 9 years ago

Latest commit fixes the previous two accessibility issues.