search

18F / myusa

MyUSA was a single sign-on project for government, now deprecated. (More info: https://18f.gsa.gov/2015/05/18/myusa/)
Other
42 stars 9 forks source link

Valid URLs for post-logout redirection were being rejected #748

Closed harrisj closed 8 years ago

harrisj commented 9 years ago

Benefits.gov was seeing an error where post-logout redirects to origin-staging.benefits.gov were being ignored because they were erroneously being flagged by a method called valid_url? (side note: Nothing makes me more annoyed than a method relying on a complicated regexp that has no tests).

Fixes #747

yozlet commented 8 years ago

@harrisj Ugh, sorry for letting this sit for so long, and thank you!