address feedback in pull request #3

18F / newrelic-terraform

New Relic Automation for TTS

https://docs.google.com/document/d/13Cf_3iMBBzmFPYyryKhRgNiC6upayeBvzEOn47Owh_c/edit

Other

0 stars 4 forks source link

address feedback in pull request #3 #13

Closed afeld closed 3 years ago

afeld commented 3 years ago

Background information

Just came across https://github.com/18F/newrelic-terraform/pull/3 again; there were a number of comments in there that weren't addressed.

Acceptance criteria

Explanation given and/or feedback addressed on master

The assignee can add some checkboxes as a "sketch" of the steps to complete, which may evolve.

JJediny commented 3 years ago

Addressed the feedback, as I changed the workflow for updating the specific comments have changed. But intent of this issue is understood and I'll make sure to avoid large PRs and documenting responses back to reviews moving forward.