Event list - Githubissues

18F / nih-oite-experiments

Experiments in support of NIH OITE project

Other

0 stars 0 forks source link

Event list #32

Closed matthinz closed 2 years ago

matthinz commented 2 years ago

Work in progress on event listing page. See Trello

Things this does

Attempts to make the "preamble" section on the events page editable in the CMS by looking up the corresponding Page model for /events
Lists all events that have not happened yet, without pagination
Uses some slightly janky, very MVP checkboxes for filtering, probably will want a consult with @dluetger and @michelle-rago about what filtering / searching options we'll want to prototype & test.

matthinz commented 2 years ago

@rahearn This is failing the ZAP scan because of lack of CSRF on the <form> I'm using for filtering. I don't think this form needs any anti-CSRF protection, but also a form may not end up being the mechanism for this filtering. But other than that I think this is ready for you to take a look.

rahearn commented 2 years ago

Forgot to add my other thoughts to the review.

1) I have some concerns about the checkbox UX, but I'm totally fine with it for now and adjust after research/design. 2) Overall, I really like the design you went with and think it's a solid foundation to build on.

matthinz commented 2 years ago

Yeah, I am 100% not intending for this to be the final UX.