search

18F / ogp-payroll

Front end for the OGP Payroll Reporting prototype project
Other
3 stars 3 forks source link

Let's create some errors on the Review Hours page! #118

Closed acolter closed 8 years ago

acolter commented 8 years ago

How about we add two error messages to https://pages.18f.gov/ogp-payroll/review-hours-and-earnings/.

The first could be a wage determination error. Maybe the bricklayer is supposed to make $25 per hour, but with rate + fringe he's only getting $20. Could highlight the rate (or rate and fringe) with an error message of "Prevailing wage is $25" or something to that effect.

The second could be a selection error. Could highlight the work classification with an error message of "Not listed on the contract." Another option would be highlighting the Carpenter (apprentice) classification with "No apprentice agreement on file" or whatever they call them.

maya commented 8 years ago

@acolter do you want the default page to have an error on those fields?

acolter commented 8 years ago

@maya The default page is fine but if there are other options let me know.

acolter commented 8 years ago

Errors look good to me