search

18F / ogp-payroll

Front end for the OGP Payroll Reporting prototype project
Other
3 stars 3 forks source link

Dashboard: Grouped entries are not selectable #80

Open LarryBafundo opened 8 years ago

LarryBafundo commented 8 years ago

In our current implementation, grouped entries are not selectable. For example, Moore & Sons has 2 subcontractors reporting to it, both of which have submitted their payroll, but the user is unable to select all of the reports associated with Moore and Sons. A user should be able to send whatever payroll is available at the second-tier level, as long as at least one of the third-tier contractors below it has submitted their payroll.

screen shot 2016-05-06 at 5 30 04 pm
hbillings commented 8 years ago

After looking at this in more detail, I don't think there's a way to make the checkbox functional without rewriting the entire table. That doesn't seem like an awesome use of time, though if others disagree I'm happy to do it! As a stopgap, I just changed one of the multiple-subs toggles to show a box that's checked, just to show you should be able to do that.

screen shot 2016-05-09 at 4 17 37 pm
hbillings commented 8 years ago

I just realized I overlooked an easy way to fake this functionality. Ignore the above!

LarryBafundo commented 8 years ago

great!

On Tue, May 10, 2016 at 3:59 AM, Heather Billings notifications@github.com wrote:

I just realized I overlooked an easy way to fake this functionality. Ignore the above!

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/18F/ogp-payroll/issues/80#issuecomment-218125290

maya commented 8 years ago

or we could change the status of these to "not received" so they wouldn't have a checkbox?

hbillings commented 8 years ago

@maya we could, yeah! I thought I submitted a PR that fixed this issue a couple days ago, but it doesn't look like it made it into the codebase...I'll see if I can figure out where it ended up.

maya commented 8 years ago

@hbillings One of them is checked now, is that what you meant?

hbillings commented 8 years ago

@maya That was my original fix, but in https://github.com/18F/ogp-payroll/pull/102 I figured out a way to fake the checking/unchecking! I just...somehow forgot to push the PR?! oy.