18F / omb-eregs

A tool to find, read, and maintain White House Office of Management and Budget (OMB) policy requirements
https://policy-beta.cio.gov/
Other
9 stars 9 forks source link

As a policy analyst or contractor, I need to know why my document failed to upload #1004

Open austinhernandez opened 6 years ago

austinhernandez commented 6 years ago

assumptions

actions

Suggestions, things to consider, notes, etc.

austinhernandez commented 6 years ago

Text needs to be finalized by @thebestsophist at another time, but here is draft text to let users know the status of the document and what they can do.

Error modal. This document failed to import.

After a successful upload

Error modal. If a user tries to leave the page or save without a document title.

thebestsophist commented 6 years ago

Updated microcopy!

Error modal. This document failed to import.

After a successful upload

Error modal. If a user tries to leave the page or save without a document title.

Text: Please give this document a title before save and closing. Action: [Focus on the title field with an error message and state.] This will help make it easier to find later.

austinhernandez commented 6 years ago

Hey @thebestsophist

Looks like some of the copy is too long. This is what it looks like in the space (sorry for not including mocks earlier.

image

I tried changing the format so it would fit, but we might need a pairing sesh for this: image

Also, not sure if the error for leaving a page without a document title needs to be a modal. I think it could just focus on the form field with error text. What do you think? image

I can set up time for a content pair, but let me know how you'd like to do content in the future!

austinhernandez commented 6 years ago

what about this copy for the 3 different states of error states?

image

cmc333333 commented 6 years ago

Quick q: does "The file was unreadable" encompass the user uploading a non-PDF (like an image or a word doc)?

rtwell commented 6 years ago

can we implement that fancy feature where files that don't have .pdf as an extension are disabled?

On Wed, Feb 14, 2018 at 11:58 AM, CM Lubinski notifications@github.com wrote:

Quick q: does "The file was unreadable" encompass the user uploading a non-PDF (like an image or a word doc)?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/18F/omb-eregs/issues/1004#issuecomment-365691751, or mute the thread https://github.com/notifications/unsubscribe-auth/AL-58aOktrLW0nPsZX5JPkICr77G0A9Kks5tUx7IgaJpZM4R-x0i .

cmc333333 commented 6 years ago

Good call, @rtwell.

yowill commented 6 years ago

Needs content approval from @thebestsophist