search

18F / omb-eregs

A tool to find, read, and maintain White House Office of Management and Budget (OMB) policy requirements
https://policy-beta.cio.gov/
Other
9 stars 9 forks source link

Refactor and document pathToResolvedPos better. #1023

Open cmc333333 opened 6 years ago

cmc333333 commented 6 years ago

Stemming from @toolness's suggestion in #1006, this adds more docs to pathToResolvedPos. It also switches the calling syntax to variadic arguments rather than an array and shuffles some non-surfaced logic around.

What do you think?

toolness commented 6 years ago

Ummm this PR is going to wreak havoc with my renaming of inline in #1021. Blarg.

toolness commented 6 years ago

Is it ok if we hold off on merging this until #1021 is merged, and then I deal with the conflicts in this branch? I am just super tired of working on footnotes and would like to get that merged ASAP if possible.

cmc333333 commented 6 years ago

Absolutely; this can wait till post demo.