search

18F / omb-eregs

A tool to find, read, and maintain White House Office of Management and Budget (OMB) policy requirements
https://policy-beta.cio.gov/
Other
9 stars 9 forks source link

In ProseMirror editor, document util.walkUpUntil() #1032

Open toolness opened 6 years ago

toolness commented 6 years ago

I was writing some code today and decided to use util.walkUpUntil() but it wasn't immediately obvious what it'd return if it didn't find a node that matched the predicate. After reading the code, I intuited that it was -1, but it'd be nice to document.

Also, it'd be nice to document the return type in the function signature too!