Discovered after the update from 18F/pages#26 successfully rebuilt, but the changes didn't appear, as reported by @emileighoutlaw. After poring over the logs and looking over the code, I realized I fell into the old trap of not returning the Promise generated by a callback, causing that Promise to execute free from the rest of the Promise chain.
Also noticed a platform-dependent test breakage after upgrading to Node v4.1.2 on my machine, and took care of that, too.
Discovered after the update from 18F/pages#26 successfully rebuilt, but the changes didn't appear, as reported by @emileighoutlaw. After poring over the logs and looking over the code, I realized I fell into the old trap of not returning the Promise generated by a callback, causing that Promise to execute free from the rest of the Promise chain.
Also noticed a platform-dependent test breakage after upgrading to Node v4.1.2 on my machine, and took care of that, too.
cc: @arowla @afeld @jeremiak