search

18F / projects

[WIP] A collection of our projects, past and present
Other
9 stars 3 forks source link

add s3 data loading support #20

Closed brendansudol closed 8 years ago

brendansudol commented 8 years ago

Why: We may want to load in data from S3 to avoid checking in large files and protect more sensitive fields.

toolness commented 8 years ago

This looks good! Thanks for making the s3 support optional.

Are you aware that boto3 actually looks at the same environment variables you're using by default? I like the explicitness of your approach, though, so it's fine if you want to leave it as-is.

Oh! Can you also note these environment variables in the README? It'd be nice to document all the environment variables in there eventually, just to make it super easy for newcomers to onboard themselves...

brendansudol commented 8 years ago

Cool, thanks. Re: variables, yeah I kinda like the explicitness of adding -- will update README accordingly, and tweak that variable name (good pt!)