Add docker support. - Githubissues

toolness commented 8 years ago

This adds support for developing the server using Docker. It includes:

Instructions on how to get started in the README.
A Dockerfile and compose file that set up the main Django app container and a postgres db container and link them together.
A Docker entrypoint that sets the user of the app container to the same uid as the host system, so that any files created by the app container don't have weird permissions on the host system. (Eventually docker will likely support such mappings itself, but for now we have to write a custom solution, which is a bit annoying.)
A convenient shortcut allowing manage.py to be used directly from the host system, under certain circumstances (see the README for more information on this).
A signal handler in manage.py allowing manage.py runserver to gracefully exit.

Note that this doesn't actually set up docker for production use. We can eventually do that if we want, though, for dev/prod parity win, but I'm not sure how compatible it is with the workings of cloud.gov or anything like that.

toolness commented 8 years ago

@brendansudol, do you want to give this a try, or should I just merge it?

brendansudol commented 8 years ago

yes, let me give it a try this morning and then we can merge!

brendansudol commented 8 years ago

this is awesome, @toolness! thanks for setting this up -- LGTM!

one small thing -- I've been using flake8 recently in python projects to keep things tidy and i really like it. how do you feel about adopting it as our linter? here's the output:

➜ flake8 
./entrypoint.py:19:1: E302 expected 2 blank lines, found 1
./entrypoint.py:26:1: E302 expected 2 blank lines, found 1
./entrypoint.py:40:13: E265 block comment should start with '# '
./manage.py:5:1: E302 expected 2 blank lines, found 1
./manage.py:39:34: E701 multiple statements on one line (colon)

toolness commented 8 years ago

Thanks, and great idea about flake8! I'll remove the commented-out line and apply the flake8 fixes and merge.

brendansudol commented 8 years ago

🚀 !

toolness commented 8 years ago

Hey @brendansudol, any idea what's up with Travis? The build log seems to indicate that it's trying to install ruby and run rake, and it's complaining that no Rakefile is present... I wonder if adding the Dockerfile or docker-compose.yml somehow made Travis think that this is a ruby project?

toolness commented 8 years ago

Hmm, I'm not sure what's going on with travis, but I'm fairly sure it's not a big deal so I'm gonna merge!

brendansudol commented 8 years ago

good eye, i think that was because we didn't have a travis config file -- i've added and it seems to be working now

18F / projects

Add docker support. #3