search

18F / projects

[WIP] A collection of our projects, past and present
Other
9 stars 3 forks source link

add client class to projects model and add fixture file with all poss… #4

Closed batemapf closed 8 years ago

batemapf commented 8 years ago

add client class to projects model and add fixture file with all possible clients. also added foreignkey to project class. also added client class to admin.

TO DO: ~need to update readme with loaddata instruction~

batemapf commented 8 years ago

added commit for readme update

brendansudol commented 8 years ago

thanks for adding this @batemapf -- this is awesome; one small thing: we're using flake8 as our python style linter (I still need to wire this up to codeclimate) and it's flagging two tiny things:

(venv)projects $ flake8 
./projects/models.py:11:1: E302 expected 2 blank lines, found 1
./projects/models.py:26:1: E302 expected 2 blank lines, found 1

(you can run on entire repo with flake8 command and can do individual files too flake8 FILE_PATH). you mind making these tweaks?

batemapf commented 8 years ago

addressed each of the line notes and ran the code through flake8 + made corrections. should be good.

brendansudol commented 8 years ago

LGTM!