search

18F / pulse

How the federal .gov domain space is doing at best practices and policies.
Other
94 stars 56 forks source link

Fix landing page links to not use canonical URL for permalink #573

Closed konklone closed 7 years ago

konklone commented 7 years ago

The error buttons were using the canonical URL instead of the domain to form permalinks, so it was going to /accessibility/domain/www.data.gov instead of /accessibility/domain/data.gov, which caused it to not be able to look up the data by domain in a11y.json.

This fixes the error buttons to always use the base domain. The canonical URL is only useful when forming links to the website itself. (Which clicking the domain link itself on the table does do.)

konklone commented 7 years ago

Self-merging for time constraints.