Closed konklone closed 8 years ago
You can see the env-var-driven hiding of accessibility endpoints in the cloud.gov deployment of the production and staging apps here:
Since the merge of master
makes the diff difficult, here are the commits that are new and unique to this pull request:
The site can now be run on cloud.gov:
We can update the DNS, in collaboration with the Cloud.gov team and the OMB MAX team, any time.
Note that the data will not update automatically anymore. We will have to manually kick off scans each week, and re-freeze the updated data into the repo and redeploy. The right place for running scans long-term in our environment is not clear, though I have copied the current scanning workhorse server AMI into our new AWS sandbox environment, and I expect to use that server for scanning for the time being.
This PR does a few things:
waitress
in production, ifPULSE_ENV
is set toproduction
.3.5.2
./accessibility/
URLs to return a 404 based on the set environment variables, rather than the code itself. This means we don't have to maintain a weird code split between branches anymore, which will simplify future feature work considerably.master
diverge fromproduction
anymore, this merges in all commits from themaster
branch that aren't inproduction
.data/db.json
is now committed to version control. It's not pretty when diffed, and even more annoyingly, it seems to change just by running the app locally. But this is by far the easiest way to freeze the data into the repository, and necessitates no other architectural changes.