search

18F / pulse

How the federal .gov domain space is doing at best practices and policies.
Other
95 stars 56 forks source link

adding history.gov to the dap exclude list #678

Closed tdlowden closed 7 years ago

gbinal commented 7 years ago

Merging. @micahsaul - game to push to production?

konklone commented 7 years ago

Hey, can someone explain why this is being filed? History.gov appears to have proper 301 server-side redirects on all of its endpoints. If it's still showing up as DAP-eligible, that points to deeper bugs that we should identify.

On Thu, Mar 30, 2017 at 8:14 AM, Tim Lowden notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/18F/pulse/pull/678 Commit Summary

  • adding history.gov

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/18F/pulse/pull/678, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAR8OCfdm5b62iLCwJx6nmG8okcfNs_ks5rq5yrgaJpZM4MuRb5 .

-- Eric Mill Senior Advisor, Technology Transformation Service, GSA eric.mill@gsa.gov, +1-617-314-0966

tdlowden commented 7 years ago

@konklone This is a similar case to america.gov. There is nothing living at the second-level domain. I was told by the folks at NARA that they are using some sort of setup that requires a subdomain. So history.gov redirects (with a 301) to historyhub.history.gov. Since there isn't any way for history.gov to implement DAP based on this configuration, it is ineligible.