search

18F / pulse

How the federal .gov domain space is doing at best practices and policies.
Other
94 stars 56 forks source link

Move a11y into the Pulse processing pipeline #711

Closed micahsaul closed 6 years ago

micahsaul commented 7 years ago

This adds the processing of a11y data from the domain-scan repo to the Pulse pipeline. Things it does not do (to come in follow-up PRs):

1) Actually turn on the automatic scanning of a11y data. There are some unresolved issues in the a11y scan that make me want to hold back for now.

2) Switch the presentation layer to use the newly processed data. This is a trivial task, but since the scan is not automatically running yet, it is premature.

3) Generate the data/domains/a11y.csv file. Same reason as above.

Next step is to pull the a11y processing stuff out of domain-scan and clear up the last scanning issues before switching it on. PRs in that repo to come.

gbinal commented 7 years ago

Looks good to me, @micahsaul. @konklone ,- if you're game to take a look, it'll be obliged. Otherwise, perhaps we merge and deploy tomorrow morning PT, @micahsaul and carefully monitor afterwards.

konklone commented 6 years ago

@micahsaul Fine from me to merge. :+1: Are you still planning to push anything here, or is this good to go?

micahsaul commented 6 years ago

@konklone nope, this is set. I'll have a follow up PR to switch the site to the new data once it's being consistently run. Thanks!

micahsaul commented 6 years ago

Woot! Thanks @konklone!