18F / pulse

How the federal .gov domain space is doing at best practices and policies.
Other
95 stars 56 forks source link

Fix DAP data display #752

Closed konklone closed 6 years ago

konklone commented 6 years ago

There was a regression in #750 that led to us showing only one result for DAP, the final entry youthrules.gov, and a success rate of 100%.

screen shot 2017-12-29 at 10 36 43 pm

This happened because only part of the analytics.csv-loading block was indented underneath the conditional that was added to allow processing when analytics.csv was missing in #750.

This was my fault, as I should have tested out #750 empirically before merging -- I eyeballed the diff and it looked fine, but the diff cuts off before showing the unindented lines.