18F / pulse

How the federal .gov domain space is doing at best practices and policies.
Other
94 stars 56 forks source link

Repair detection of SSLyze results where connection couldn't be established #754

Closed konklone closed 6 years ago

konklone commented 6 years ago

The hacky workaround I was using in #748 and #751 to detect situations when connectivity was not established during SSLyze scanning stopped working.

The better solution would be a field whose value was just true/false on whether connectivity was established, but in its absence, this fixes the hacky workaround so that affected agencies will see some relief ASAP.

egyptiankarim commented 6 years ago

Thanks for pushing this!