search

18F / pulse

How the federal .gov domain space is doing at best practices and policies.
Other
94 stars 56 forks source link

Data as a package #774

Closed buckley-w-david closed 6 years ago

buckley-w-david commented 6 years ago

Greetings from your friends to the north!

As I believe you are aware, the Canadian Digital Service is interested in similar work that prompted 18F to create Pulse, and is thinking of using Pulse as a base to build off of.

In the course of investigating we've made a few refactors to bring it closer in line with how we would structure such a system (with more refactoring changes planned).

This PR is mostly to see if you're interested in incorporating any of the changes we're going to be making.

As of yet not a lot has changed, We've made data into a package (This PR), prints throughout have been subbed out with calls to methods from the logging module, and some small testing has been setup.

Soon however we will be implementing changes that would be breaking backwards compatibility with the existing system (such as a change to the CLI interface, and later actual functionality changes). Before we get to this point I figured it'd be best to reach out and see if you'd like any of the changes before we get to that incompatibility point.

If you're interested I can make PRs for the rest of the changes that shouldn't break functionality or interface.

Let me know.

konklone commented 6 years ago

Greetings from your friends to the north!

Greetings! 🍁 ☃️

We're happy to help support you using this repo as a base for the work.

If you're interested I can make PRs for the rest of the changes that shouldn't break functionality or interface.

Absolutely. We'd love to minimize the divergence between our codebase and your codebase, and any tech debt fix-ups are super welcome.

Soon however we will be implementing changes that would be breaking backwards compatibility with the existing system (such as a change to the CLI interface, and later actual functionality changes).

If you want to open an issue to discuss the kinds of changes you'll be making, it might be helpful to figure out if there's a clear/clean way to pull out a shared core that we could both stay on, even if it means another repo is involved.

We've had a bunch of people fork Pulse, and almost all of them had to like, strip it down to a simpler core thing, and it's made it very clear that a "Pulse lite" base would likely be useful and ultimately save us all work keep us well-aligned.