search

18F / pulse

How the federal .gov domain space is doing at best practices and policies.
Other
94 stars 56 forks source link

New consolidated CLI #786

Open buckley-w-david opened 6 years ago

buckley-w-david commented 6 years ago

As per https://github.com/18F/pulse/issues/783, this PR proposes a replacement to the current CLI, with the interface outlined therein, with a change that the command is pulse instead of data.

konklone commented 6 years ago

@buckley-w-david Thanks for your patience - I just resolved the slight merge conflict from the couple PRs that got merged before this. I'll review this shortly.

Also, are you up for joining a Slack channel 18F/TTS runs, with a few other relevant folks, about this work? If so, do you want to send a quick email to eric.mill@gsa.gov to share your work email with me?

buckley-w-david commented 6 years ago

Sounds good, I sent you an email.

I urge caution on actually merging in this change, it's fairly large and interfaces with large untested portions of the code, so we should be quite careful with it.

The tests included strictly only test the CLI itself

konklone commented 6 years ago

Yeah, that's part of the delay -- it needs some dedicated human testing.

buckley-w-david commented 6 years ago

Do not remember closing this one, re-opening in case the features are still wanted